Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in STUDY PROTOCOLS section #14

Open
Hannah-Doerpholz opened this issue Feb 2, 2023 · 0 comments
Open

Inconsistency in STUDY PROTOCOLS section #14

Hannah-Doerpholz opened this issue Feb 2, 2023 · 0 comments

Comments

@Hannah-Doerpholz
Copy link

I notices while reading your specification that in the section STUDY PROTOCOLS the field "Study Protocol Parameters Name" and its two ontology field "Term Source REF" and "Term Accession Number" are used. However, while in your specification (and here: https://github.com/ISA-tools/isa-specs/blob/master/source/_static/isatab/study_protocols.csv) those fields are described as follows:

Study Protocol Parameters Term Accession Number
Study Protocol Parameters Term Source REF

in your own examples (https://github.com/ISA-tools/isa-specs/blob/master/source/_static/isatab/i_investigation.txt and https://github.com/ISA-tools/isa-specs/blob/master/source/_static/isatab/i_gilbert.txt) it is different:

Study Protocol Parameters Name Term Accession Number
Study Protocol Parameters Name Term Source REF

Personally, I find it more intuitive to add "Name" like in the examples, since it more accurately describes that the ontology fields belong to the "Study Protocol Parameters Name". Which of the two versions should be used in new files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant