Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not ensure that ISA-Tabs are in utf-8 #327

Open
drj11 opened this issue Feb 9, 2018 · 4 comments
Open

Does not ensure that ISA-Tabs are in utf-8 #327

drj11 opened this issue Feb 9, 2018 · 4 comments

Comments

@drj11
Copy link

drj11 commented Feb 9, 2018

(as discussed face-to-face on 2017-02-05)

What originated as a bug in our data repository, hidelab/genometranslationcommons#14, turns out to be because the ISA-Tab created by ISAcreator wasn't encoded in utf-8 and that turned out to be because Java on Windows doesn't particularly guarantee that.

@drj11
Copy link
Author

drj11 commented Feb 9, 2018

Solutions that would improve the matter:

  1. The Java program could override the system locale and just write everything in utf-8.
  2. Warn when saving if the encoding isn't utf-8.
  3. Selectable from a menu.

I think I strongly prefer 1 (are there users that want ISA-Tab files that aren't utf-8?).

It's possible that we could achieve that by setting an option when java is invoked.
My brief research leads me to https://groups.google.com/forum/#!topic/isaforum/03P91ZQ1mj0 which suggests -Dfile.encoding=utf-8.

But I don't know how Java programs are packaged or launched.

@DanBerrios
Copy link

on Windows you can write a shell script to start up ISACreator using UTF-8 encodings. Here's the one I wrote:

echo. Starting ISAcreator
java -Dfile.encoding=utf-8 -Xmx1024m -Xms512m -jar ISAcreator.jar

@drj11
Copy link
Author

drj11 commented Mar 8, 2018

ah thanks @DanBerrios, I don't use Windows myself but this will be useful

@drj11
Copy link
Author

drj11 commented Mar 13, 2018

an example unicode character: ≤

as in 5 ≤ 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants