Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISAcreator creates multiple Protocols with the same Name if they have the same type #287

Open
proccaserra opened this issue Jul 29, 2014 · 3 comments

Comments

@proccaserra
Copy link
Member

reported by Steffen:
if an ISA configuration defines several tables using the same Protocol Type (say 'data transformation'), ISAcreator upon creation of the assay tables, automatically creates the relevant Protocol objects in the investigation file. The problem is that ISAcreator will create 'duplicates' as "Protocol Name" value is set using the 'Protocol Type':

Fix: -> unique 'Protocol Name' but keep the Protocol Type as supplied by the configuration

@proccaserra
Copy link
Member Author

Also reported as a nuisance by Metabolights

@eamonnmag
Copy link
Member

do you want to append the assay type to the protocol name? fixing is easy, it's just a matter of deciding how to name things.

@proccaserra
Copy link
Member Author

we need a counter as we could have 4 assay tables, for instance 2 NMR assays and 2 MS assays, all protocols used in each could share types but be different. Counting the number of assay type would allow to unique the protocol. Note: modulation could be achieved too with uniquing the Protocol Name (as those are set based on 'Protocol Type' found in the configuration

@eamonnmag eamonnmag modified the milestone: 1.7.9 Oct 24, 2014
@djcomlab djcomlab removed this from the 1.7.9 milestone Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants