Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdav1d support #479

Open
roychen1998 opened this issue Aug 24, 2022 · 7 comments
Open

libdav1d support #479

roychen1998 opened this issue Aug 24, 2022 · 7 comments
Assignees
Labels

Comments

@roychen1998
Copy link

I tried to enable libdav1d in YUView to analyze a AV1 stream, then some trouble met.

  1. It seems that "dav1d_default_analyzer_settings" has been renamed to "dav1d_default_analyzer_flags" in dav1d_0.2.1.0.analyze (https://github.com/IENT/YUView/wiki/External-Decoders). I have rename the function in my local, but I am not sure whether there is still some other issues here.
  2. getExtradata() return "", and it lead to a crash in "header.parse(reader)" in functions "FileSourceFFmpegFile::getParameterSets()“.

Is there any help to make libdav1d work? Or is there a release with libdav1d?

@ChristianFeldmann
Copy link
Member

Hi. Thanks for the report. I did not check decoding with dav1d for a long time. I will try to recreate it.

@ChristianFeldmann ChristianFeldmann self-assigned this Aug 26, 2022
@ChristianFeldmann ChristianFeldmann changed the title libdav1d suuport libdav1d support Aug 26, 2022
@ChristianFeldmann
Copy link
Member

Something is definitely wrong or has changed until I last used the david decoder natively. (It can also be used through FFmpeg which should still work). I found some bugs for pushing data and parsing extradata from the packets but it is still not fully functional again.

@roychen1998
Copy link
Author

Thanks for the update.

@roychen1998
Copy link
Author

Hi Christian,
Here is some of my fix to make dav1d work FYI. Attachment is a diff file based on #489.

fix_diff.txt

@ChristianFeldmann
Copy link
Member

Hi. Sorry I was not able to merge that yet. I fixed a bug in YUView for parsing AV1 files from containers but this issue I think is not solved yet. Or why did you close it?

@roychen1998
Copy link
Author

roychen1998 commented Nov 16, 2022 via email

@ChristianFeldmann
Copy link
Member

Ah ok. I will leave this open because I would like to fix this for good in the main branch. I am also working on a bunch of refactorings and better testing of the components.
For the networ: You can start YUView with -noUpdate. This should disable the update check and no connection to the internet is performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants