Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fetching particles.json each time the theme is switched #86

Open
nishant-nayak opened this issue Jan 6, 2024 · 0 comments
Open
Labels
bug Something isn't working frontend Frontend (HTML, CSS, JS) related issues p2 Priority 2 tasks. Affects most users
Milestone

Comments

@nishant-nayak
Copy link
Member

The logic for updating the Particles config on the public facing pages needs to be fixed in dark_mode_toggle.html. The current logic fetches the particles.json everytime the theme is switched. This leads to unnecessary network calls and visible lag in the particles after many changes.

The logic has to be updated to either updated the config without a config file (directly modifying the JS parameters) or fetching both files once and storing them locally for each switch.

@nishant-nayak nishant-nayak added bug Something isn't working frontend Frontend (HTML, CSS, JS) related issues p2 Priority 2 tasks. Affects most users labels Jan 6, 2024
@nishant-nayak nishant-nayak added this to the v0.1 milestone Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend (HTML, CSS, JS) related issues p2 Priority 2 tasks. Affects most users
Projects
None yet
Development

No branches or pull requests

1 participant