Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: extract async tasks codebase in its own lib #1384

Open
ClemDoum opened this issue Apr 17, 2024 · 1 comment
Open

feature: extract async tasks codebase in its own lib #1384

ClemDoum opened this issue Apr 17, 2024 · 1 comment
Assignees
@bamthomas @ClemDoum @mvanzalu
Labels
feat

Comments

@ClemDoum
Copy link
Contributor

Replaces #1185

Current limitations

As explained in #1185, extensions and other codebases must be able to create, start and potentially monitor tasks. Create tasks from extension will be required in https://github.com/ICIJ/datashare-extension-neo4j as well as in other projects.

Currently, this is not possible.

Solution

@bamthomas suggested to extract task related objects TaskView, TaskManager, TaskSupplier... in their own lib inside this monorepo, the lib will be published in its own jar in order to be imported where relevant. The lib could be named datashare-tasks, datashare-async-tasks...
@ClemDoum ClemDoum added the feat label Apr 17, 2024
@ClemDoum ClemDoum mentioned this issue Apr 17, 2024
Closed
@ClemDoum ClemDoum mentioned this issue May 14, 2024
Open
bamthomas added a commit that referenced this issue May 14, 2024
@bamthomas @ClemDoum @mvanzalu
fix: automated tests #1384
8ae2de6 
Co-authored-by: Clément Doumouro <ClemDoum@users.noreply.github.com>
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 15, 2024
@bamthomas
ci: fix package by upgrading maven shade plugin #1384
b13538d
bamthomas added a commit that referenced this issue May 15, 2024
@bamthomas
refactor: make ds-tasks heritate from datashare pom #1384
086d2b1
bamthomas added a commit that referenced this issue May 15, 2024
@bamthomas
ci: fix version extraction that were merging with mockito version #1384
b187654
bamthomas added a commit that referenced this issue May 15, 2024
@bamthomas
refactor: move BlockingQueues mem/redis into app module #1384
4a4b6e8
bamthomas added a commit that referenced this issue May 21, 2024
@bamthomas @mvanzalu
feat: add a StatusLatch sync object #1384
a60912e 
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 21, 2024
@bamthomas @mvanzalu
refactor: no need for class template #1384
ce99188 
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 21, 2024
@bamthomas @mvanzalu
refactor: test event based instead of polling #1384
ca04e69 
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 27, 2024
@bamthomas
fix: test it seems that elapse time can be equal to expected #1384
e992630
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 40 days with no activity.

@github-actions github-actions bot added the stale label May 28, 2024
@ClemDoum ClemDoum removed the stale label May 28, 2024
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
refactor: extract redisson version into datashare pom #1384
606b55c
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
chore: apply feedbacks from CD #1384
a8c213b
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas @ClemDoum @mvanzalu
fix: automated tests #1384
fd8df8b 
Co-authored-by: Clément Doumouro <ClemDoum@users.noreply.github.com>
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
ci: fix package by upgrading maven shade plugin #1384
9034c55
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
refactor: make ds-tasks heritate from datashare pom #1384
8291fc9
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
ci: fix version extraction that were merging with mockito version #1384
77cdde7
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
refactor: move BlockingQueues mem/redis into app module #1384
0b50c20
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas @mvanzalu
feat: add a StatusLatch sync object #1384
d569972 
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas @mvanzalu
refactor: no need for class template #1384
7f783dc 
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas @mvanzalu
refactor: test event based instead of polling #1384
a166cff 
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
fix: test it seems that elapse time can be equal to expected #1384
384b7ab
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
refactor: extract redisson version into datashare pom #1384
cf64469
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
chore: apply feedbacks from CD #1384
3dc89d8
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas @ClemDoum @mvanzalu
fix: automated tests #1384
c9c0cac 
Co-authored-by: Clément Doumouro <ClemDoum@users.noreply.github.com>
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
ci: fix package by upgrading maven shade plugin #1384
5513ef7
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
refactor: make ds-tasks heritate from datashare pom #1384
ac55129
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
ci: fix version extraction that were merging with mockito version #1384
7342ab5
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
refactor: move BlockingQueues mem/redis into app module #1384
1ac9d79
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas @mvanzalu
feat: add a StatusLatch sync object #1384
fe0a557 
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas @mvanzalu
refactor: no need for class template #1384
dbdfefa 
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas @mvanzalu
refactor: test event based instead of polling #1384
8308738 
Co-authored-by: Maxime Vanza Lutonda <mvanzalu@users.noreply.github.com>
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
fix: test it seems that elapse time can be equal to expected #1384
6e04f53
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
refactor: extract redisson version into datashare pom #1384
f27eee1
bamthomas added a commit that referenced this issue May 28, 2024
@bamthomas
chore: apply feedbacks from CD #1384
9a68ef8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bamthomas bamthomas

@ClemDoum ClemDoum

@mvanzalu mvanzalu

Labels
feat
Projects
Sprint 25
Status: In Progress
Sprint 26
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bamthomas @ClemDoum @mvanzalu