Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extension): Info overlay for web page doesn't inspect the element underneath #1894

Merged
merged 7 commits into from May 8, 2024
Merged

fix(extension): Info overlay for web page doesn't inspect the element underneath #1894

merged 7 commits into from May 8, 2024

Conversation

drjoho
Copy link
Contributor

@drjoho drjoho commented Apr 17, 2024 •
edited by tombrunet

  • Extension UI bug

This PR is related to the following issue(s):

Fixes #1854

Additional information can be found here:

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@drjoho drjoho changed the title add pointer-event none only to element overlay fix(extension): add pointer-event none only to element overlay Apr 17, 2024
@drjoho drjoho changed the title fix(extension): add pointer-event none only to element overlay fix(extension): Info overlay for web page doesn't inspect the element underneath Apr 17, 2024
@tombrunet
Copy link
Member

@drjoho I think I've fixed #1056 also, but please confirm. I think there are some potential tweaks to the items at the top of the page, but works well enough. Will also need the related user guide updates to remove the warnings.

drjoho
drjoho commented May 6, 2024
View reviewed changes
Copy link
Contributor Author

@drjoho drjoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and is fine. Also checked that the keyboard drawing do not reappear if keyboard mode off.

@ErickRenteria ErickRenteria added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit e1ca4a7 May 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrunet tombrunet tombrunet approved these changes

Assignees

@ErickRenteria ErickRenteria

Labels
Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Info overlay for web page doesn't inspect the element underneath
3 participants
@drjoho @tombrunet @ErickRenteria