Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiverseLabelsSamples clarification #740

Open
yoavkatz opened this issue Mar 31, 2024 · 0 comments
Open

DiverseLabelsSamples clarification #740

yoavkatz opened this issue Mar 31, 2024 · 0 comments
Assignees

Comments

@yoavkatz
Copy link
Member

yoavkatz commented Mar 31, 2024

DiverseLabelsSampler is used to select few shot examples.

  1. The name is not clear. It should be something DiverseDemosSampler.

  2. DiverseLabelsSampler requires adding a choices field - which requires adding a field to the task (although demo selection is not a property of the task:

  sampler=DiverseLabelsSampler(
        choices="choices", labels="is_faithful", include_empty_label=False
    ),

Suggested refinement implementation:

demos_sampler=DiverseDemosSampler(
        choices=["yes", "no"], label_field="is_faithful", include_empty_labels=False
    ),

or

    demos_sampler=DiverseDemosSampler(
        choices_field="choices", label_field="is_faithful", include_empty_labels=False
    )

if we want to keep also the old behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants