Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadFromIBMCos does not work if datafile has '/' in name #708

Open
yoavkatz opened this issue Mar 25, 2024 · 0 comments
Open

LoadFromIBMCos does not work if datafile has '/' in name #708

yoavkatz opened this issue Mar 25, 2024 · 0 comments

Comments

@yoavkatz
Copy link
Member

data_dir=“tuning-data-cleared/ceramic/mixtures_02.26.2024/code/dolphin_coder”,
data_files={“train”: “train/part0.jsonl”, “test”: “val/part0.jsonl”},

This causes failures.

Possible solution:

  1. Raise an error if '/' in data_files, but allow fusing of datasource (see Add ability to fuse sources with disjoint splits  #707)
  2. Handle '/' in paths. (simpler for users)
@yoavkatz yoavkatz changed the title LoadFromIBMCos does not work if datafile LoadFromIBMCos does not work if datafile has '/' in name Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant