Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add notion of SubTask #694

Open
elronbandel opened this issue Mar 20, 2024 · 1 comment
Open

Suggestion: Add notion of SubTask #694

elronbandel opened this issue Mar 20, 2024 · 1 comment

Comments

@elronbandel
Copy link
Member

elronbandel commented Mar 20, 2024

Today we have tasks such as tasks.classification.mutli_class that are very general by using things like: class_type then we can have sentiment and emotion classification under the same task by using AddFields(fields={"class_type":"sentiment") for sentiment for example.

I suggest to add a concept of SubTask that is also a Task but can be made by filling fields of the Task it inherits from.

For example tasks.classification.mutli_class.sentiment_extraction:

SubTask(parent="tasks.classification.mutli_class", with={"class_type": "sentiment"})

That way you can enjoy both worlds: (1) have very general tasks with templates that can fit many tasks (2) when needed you can create specific template for specific tasks.

@yoavkatz
Copy link
Member

I think different tasks have both different defaults and different field names. It's a question of whether adding a new concept will have a significant advantage over just reusing the basic building blocks (metrics, templates classes, post processors).

In general, I think tasks should have the options for default field names (e.g. "text_type": "text")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants