Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible full import needed in unitxt.dataset #514

Open
sam-data-guy-iam opened this issue Jan 23, 2024 · 1 comment
Open

possible full import needed in unitxt.dataset #514

sam-data-guy-iam opened this issue Jan 23, 2024 · 1 comment

Comments

@sam-data-guy-iam
Copy link
Collaborator

sam-data-guy-iam commented Jan 23, 2024

@matanor unitxt/src/unitxt/dataset.py currently has from .from .dataset_utils import get_dataset_artifact
I just newly cloned both fm-eval and unitxt, and rebuilt the envs. For me, when I try running the basic run_text2text.py task from fm-eval, I get an error that dataset doesn't have the parse method. Should this statement be instead from .dataset_utils import *? This fixes it for me.

@matanor
Copy link
Member

matanor commented Feb 22, 2024

I think its ok, you can see in other files that this is how imports go within src/unitxt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants