Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

Performance issues in /hangul_model.py (by P3) #72

Open
DLPerf opened this issue Aug 30, 2021 · 1 comment
Open

Performance issues in /hangul_model.py (by P3) #72

DLPerf opened this issue Aug 30, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 30, 2021

Hello! I've found a performance issue in /hangul_model.py: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.

Detailed description is listed below:

  • .batch(BATCH_SIZE)(here) should be called before .map(_parse_function)(here).
  • .batch(BATCH_SIZE)(here) should be called before .map(_parse_function)(here).

Besides, you need to check the function called in map()(e.g., _parse_function called in .map(_parse_function)) whether to be affected or not to make the changed code work properly. For example, if _parse_function needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@DLPerf
Copy link
Author

DLPerf commented Nov 4, 2021

Hello, I'm looking forward to your reply~

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant