Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Unify format of data_sets and files_to_use in DataAccessFactory #71

Closed
2 tasks done
daw3rd opened this issue May 6, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@daw3rd
Copy link
Member

daw3rd commented May 6, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

Library/core

Feature

According to the way the data-processing-lib parses the parameter data_data_sets, the datasets should be passed as a line (String) with the names of the datasets separated by ",". For example dataset1,dataset2.
While the parameter data_files_to_use should be passed as a list (with []) that includes strings with '. For example ['.ext1', '.ext2'].

This difference is caused by the difference in parsing these two parameters in the library. I think we should unify the way of parsing by changing the way of parsing the data_data_sets to use type=ast.literal_eval. For example:

parser.add_argument(
            f"--{self.cli_arg_prefix}data_sets",
            type=ast.literal_eval,
            default=None,
            help="List of data sets",
        )

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@daw3rd daw3rd added the enhancement New feature or request label May 6, 2024
@blublinsky
Copy link
Collaborator

@daw3rd, this is done. Can we close it?

@daw3rd
Copy link
Member Author

daw3rd commented May 14, 2024

yes, we need to mark things "fixed", then they can get attention when browsing the issues.

@daw3rd daw3rd closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants