Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingest2parquet Makefile needs new run-*-sample targets similar to transforms #46

Closed
daw3rd opened this issue May 1, 2024 · 1 comment
Closed

ingest2parquet Makefile needs new run-*-sample targets similar to transforms #46

daw3rd opened this issue May 1, 2024 · 1 comment
Assignees
@sapthasurendran
Labels
fixed Marks an issues as fixed in the dev branch

Comments

@daw3rd
Copy link
Member

daw3rd commented May 1, 2024

At least

run-local-sample
run-s3-sample

Like the transforms, the run-s3-sample should start and load the minio server and then ask the user to stop the minio server.
Starting/loading/stopping minio should be done with the following make targets, like the transforms

minio-start - start and load test-data/input
minio-stop - stops the server

.make.defaults has support for these.
@daw3rd daw3rd assigned Param-S and sapthasurendran and unassigned Param-S May 1, 2024
@sapthasurendran sapthasurendran mentioned this issue May 7, 2024
Merged
@sapthasurendran sapthasurendran added the fixed Marks an issues as fixed in the dev branch label May 15, 2024
@daw3rd
Copy link
Member Author

daw3rd commented May 15, 2024

verified

@daw3rd daw3rd closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sapthasurendran sapthasurendran

Labels
fixed Marks an issues as fixed in the dev branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daw3rd @Param-S @sapthasurendran