Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github doc pages hyperlinks and formatting issues #43

Open
nirmdesai opened this issue May 1, 2024 · 7 comments
Open

Github doc pages hyperlinks and formatting issues #43

nirmdesai opened this issue May 1, 2024 · 7 comments
Assignees

Comments

@nirmdesai
Copy link
Collaborator

The hyperlinks on this doc page ends up downloading the .py files instead of navigating the browser to the specific code file in the repo: https://ibm.github.io/data-prep-lab/data-processing-lib/doc/overview/

Same issue exists for this page and probably other such pages: https://ibm.github.io/data-prep-lab/data-processing-lib/doc/transform-tutorials/

Numbered list on this page is not correctly formatted, and the powerpoint diagram looks weird with grammar mistake highlights: https://ibm.github.io/data-prep-lab/data-processing-lib/doc/architecture/

@shahrokhDaijavad
Copy link
Member

@nirmdesai Pages created via MkDocs need manual fixing of links with relative paths. We are aware of this and I have asked Shivdeep to do this.

@daw3rd
Copy link
Member

daw3rd commented May 2, 2024

And to be clear, these links work when viewing from github.com, just seems mkdocs is doing something wrong. For example, the .py links work as expected from https://github.com/IBM/data-prep-lab/blob/dev/data-processing-lib/doc/transform-tutorials.md

@shahrokhDaijavad
Copy link
Member

@shivdeep-singh-ibm Have you looked at this and found no solution yet? If there is no solution for referring to python pages in transforming repo with MkDoc to Pages, we should link to Readme pages in the respective directories. As for the formatting issue (the third link above), I think there should be a way to fix this, no?

@shivdeep-singh-ibm
Copy link
Collaborator

shivdeep-singh-ibm commented May 6, 2024

I have found 1 way. I am preparing a patch for it. That method is working for python cases, trying to handle some corner cases as well.

The approach is to use hooks.py as a hook to mkdocs , which will automatically update the links (relative links to python files or relative links to repo folders), with. absolute github links to repo on the fly while generatig the documentation.

eg.
[transform](./transform/src/main.py) will become [transform](https://github.com/IBM/data-prep-lab/blob/dev/transform/src/main.py)
this way it will open github on clicking the link.

I need to support only

  • relative links to python files
  • relative links to folders
  • not to update http/ssh/protocl type links

@shahrokhDaijavad
Copy link
Member

Sounds good, @shivdeep-singh-ibm! Thank you.

@shahrokhDaijavad
Copy link
Member

I see that the link to the python files has been fixed, but the formatting issue in the page https://ibm.github.io/data-prep-kit/data-processing-lib/doc/architecture/ is still there.

@shahrokhDaijavad
Copy link
Member

shahrokhDaijavad commented May 14, 2024

@shivdeep-singh-ibm Thanks for making the file a lot better by adding new lines. Sorry for nitpicking, but there is still a problem with the indention of bullets and sub-bullets, as I compare the repo Readme with the corresponding Pages version of the architecture.md file. As I look at the markdown file, I see a different color of * for bullets and sub-bullets. Repo treats this correctly, but Pages doesn't. I think the sub-bullets that are red color * should become black for the pages to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants