Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "Simplest Transform Tutorial" hard-codes IBM Cloud information #107

Open
1 of 2 tasks
deanwampler opened this issue May 10, 2024 · 1 comment
Open
1 of 2 tasks
Assignees
Labels
bug Something isn't working fixed Marks an issues as fixed in the dev branch

Comments

@deanwampler
Copy link
Contributor

Search before asking

  • I searched the issues and found no similar issues.

Component

Documentation

What happened + What you expected to happen

Running the "simplest" tutorial assumes IBM Cloud:

python noop_main.py --noop_sleep_msec 2 \
  --run_locally True  \
  --s3_cred "{'access_key': 'KEY', 'secret_key': 'SECRET', 'cos_url': 'https://s3.us-east.cloud-object-storage.appdomain.cloud'}" \
  --s3_config "{'input_folder': 'cos-optimal-llm-pile/test/david/input/', 'output_folder': 'cos-optimal-llm-pile/test/david/output/'}"

Can you provide some dummy test data in the repo and use that instead? What would be the command-line flags for local storage?

It's fine with me to leave in an S3 (true S3) example for those users so equipped, but otherwise, this is hardly a "local" example and I'm currently blocked.

I would try submitting a PR, but I'm not sure what the changed CLI flags would be for local use.

Reproduction script

N/A

Anything else

No response

OS

MacOS (limited support)

Python

3.11.x

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@deanwampler deanwampler added the bug Something isn't working label May 10, 2024
@daw3rd daw3rd self-assigned this May 10, 2024
@daw3rd
Copy link
Member

daw3rd commented May 10, 2024

I pushed PR #110 that I believe fixes this and a lot of the other docs to match recent refactorings.

@daw3rd daw3rd added the fixed Marks an issues as fixed in the dev branch label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Marks an issues as fixed in the dev branch
Projects
None yet
Development

No branches or pull requests

2 participants