Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-greenhouse gas emission species #47

Open
danielhuppmann opened this issue Feb 15, 2024 · 1 comment
Open

Add non-greenhouse gas emission species #47

danielhuppmann opened this issue Feb 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@danielhuppmann
Copy link
Member

While working on some sanity-checks for the new IAMC project templates, I realized that several emissions species are relevant for IAM reporting but are not included in the list of emissions - because they are not greenhouse gases.

I suggest to add them anyway here so that pyam and a unit-validation-schema can directly build on ism-units (instead of requiring a separate solution).

I was trying to use the following line to check whether a unit like "Mt BC/yr" is valid.

iam_units.emissions.pattern.split(unit)

This fails for the following emissions species:
BC, CO, NH3, NO2, OC, SO2, VOC, HFC43-10

Of course, trying to convert them using GWP should (continue to) fail.

Any objections @khaeru @phackstock?

@danielhuppmann danielhuppmann self-assigned this Feb 15, 2024
@khaeru
Copy link
Contributor

khaeru commented Feb 16, 2024

Sure, this seems safe to do. A clean way would be to extend SPECIES with:

  1. One element "\w+" that should cover most cases without the need for future fiddling.
  2. Additional elements like "HFC43-10" where they contain characters used elsewhere in the regex.

That would result in the constructed pattern looking and working something like this: https://regex101.com/r/pQ2Kf3/1

Note that the order of (1) and (2) matters. Maybe it doesn't, but please check.

Please also add a comment above these two elements at the bottom of the list to explain the distinction.

@khaeru khaeru added the enhancement New feature or request label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants