Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is CodeList.name needed? #230

Open
phackstock opened this issue Mar 8, 2023 · 1 comment
Open

Is CodeList.name needed? #230

phackstock opened this issue Mar 8, 2023 · 1 comment

Comments

@phackstock
Copy link
Contributor

As we were discussing #226, I was wondering if there is any use for the CodeList.name attribute.
I was looking over the code and I didn't really find any.
I suppose it's good to remove?
What do you think @danielhuppmann?

@danielhuppmann
Copy link
Member

It was originally intended to store the dimension of the CodeList (region, variable, scenario). Given that we will not have dedicated sub-classes for all possible dimensions (because a user could always create a new dimension), I would keep it for now.

But if that's not yet the case, we can ensure that the name attribute is always matched to the dimension name for the sub-classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants