Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Investigate react/prop-types eslint rule #499

Open
matteovivona opened this issue Jul 4, 2020 · 2 comments
Open

Investigate react/prop-types eslint rule #499

matteovivona opened this issue Jul 4, 2020 · 2 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@matteovivona
Copy link
Contributor

matteovivona commented Jul 4, 2020

Recently, a rule for react/prop-types was made a warning.

This issue is to investigate whether or not it is needed and to turn the rule off or to make it an error and fix the relevant code.

@matteovivona matteovivona added bug Something isn't working help wanted Extra attention is needed core-team and removed help wanted Extra attention is needed labels Jul 4, 2020
@matteovivona
Copy link
Contributor Author

matteovivona commented Jul 4, 2020

I added this annotation in the Modal.tsx

/* eslint react/prop-types: 0 */

@HospitalRun/core-contributor is that a rule we need? Otherwise, you can disable it globally with

  "rules": {
    "react/prop-types": 0
  }

@jackcmeyer
Copy link
Member

For now, I have made this a warning.

@jackcmeyer jackcmeyer added this to To do in Version 2.0 via automation Jul 8, 2020
@jackcmeyer jackcmeyer changed the title 'toggle' is missing in props validation Investigate react/prop-types eslint rule Jul 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Version 2.0
  
To do
Development

No branches or pull requests

4 participants