Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Fortawesome: treeshaking behavior not working #278

Open
ocBruno opened this issue Feb 15, 2020 · 6 comments
Open

Fortawesome: treeshaking behavior not working #278

ocBruno opened this issue Feb 15, 2020 · 6 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Milestone

Comments

@ocBruno
Copy link
Contributor

ocBruno commented Feb 15, 2020

馃悰 Bug Report

After looking at the size of the build and the config I noticed the whole free-solid-svg-icons library was being imported.

To reproduce

yarn clone github.com/hospitalrun/components
view index.tsx file

This bug is related to following issue as it is taking up space in the hospitalrun build

HospitalRun/hospitalrun-frontend#1808

Expected behavior

Only import necessary icons

  • node version: 12.16.0
  • os: Windows
@matteovivona matteovivona added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 15, 2020
@matteovivona
Copy link
Contributor

Some reference: https://fontawesome.com/how-to-use/with-the-api/other/tree-shaking

@matteovivona matteovivona added this to To do in Version 2.0 via automation Feb 15, 2020
@matteovivona matteovivona added this to the v1.0.0 milestone Feb 15, 2020
@matteovivona matteovivona added the bug Something isn't working label Feb 15, 2020
@ocBruno
Copy link
Contributor Author

ocBruno commented Feb 15, 2020

Some reference: https://fontawesome.com/how-to-use/with-the-api/other/tree-shaking

Thanks for the reference, this is what I was using to debug but I attempted various methods with no success and stopped at the custom build configs. Not sure if anyone with rollup experience wants to tackle this..

@matteovivona matteovivona changed the title bug(fortawesome): treeshaking behavior not working Fortawesome: treeshaking behavior not working Feb 20, 2020
@matteovivona
Copy link
Contributor

@lloui-donut which commit do you refer to?

@matteovivona
Copy link
Contributor

seems to be a commit that was never merged into the main repo...

@ChrisDryden
Copy link

A group of students from a university course was hoping to take this on for an open-source assignment, could we take this on?

@ghost
Copy link

ghost commented Jan 15, 2022

@ocBruno I'd like to work on this issue

@matteovivona matteovivona assigned ghost Jan 15, 2022
@ghost ghost removed their assignment Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Version 2.0
  
To do
Development

No branches or pull requests

3 participants