Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixxx 2.4.1 #173531

Merged
merged 1 commit into from May 11, 2024
Merged

mixxx 2.4.1 #173531

merged 1 commit into from May 11, 2024

Conversation

krehel
Copy link
Member

@krehel krehel commented May 11, 2024

Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label May 11, 2024
@krehel krehel marked this pull request as draft May 11, 2024 23:25
auto-merge was automatically disabled May 11, 2024 23:25

Pull request was converted to draft

@krehel
Copy link
Member Author

krehel commented May 11, 2024

Going to push some updates

@krehel krehel marked this pull request as ready for review May 11, 2024 23:30
@samford
Copy link
Member

samford commented May 11, 2024

Going to push some updates

I was just about to push the same changes but you beat me to it 😆

The MacOS dependency appeared to be different based on the architecture when I tested this locally (macOS 14.4.1 ARM):

$ brew audit --strict --online --arch all mixxx
==> Downloading and extracting artifacts
==> Downloading https://downloads.mixxx.org/releases/2.4.1/mixxx-2.4.1-macosinte
Already downloaded: /Users/<user>/Library/Caches/Homebrew/downloads/8b77b9c8c4c58c4dcc4087168a1cb7902fb7853a12943789b2b3120b88048ffe--mixxx-2.4.1-macosintel.dmg
==> Downloading https://downloads.mixxx.org/releases/2.4.1/mixxx-2.4.1-macosinte
Already downloaded: /Users/<user>/Library/Caches/Homebrew/downloads/8b77b9c8c4c58c4dcc4087168a1cb7902fb7853a12943789b2b3120b88048ffe--mixxx-2.4.1-macosintel.dmg
==> Downloading and extracting artifacts
==> Downloading https://downloads.mixxx.org/releases/2.4.1/mixxx-2.4.1-macosarm.
Already downloaded: /Users/<user>/Library/Caches/Homebrew/downloads/d6216fd9b658c9389e2f3eaef9889f2e0b61484e0753200e4fa93f0986099ba4--mixxx-2.4.1-macosarm.dmg
==> Downloading https://downloads.mixxx.org/releases/2.4.1/mixxx-2.4.1-macosarm.
Already downloaded: /Users/<user>/Library/Caches/Homebrew/downloads/d6216fd9b658c9389e2f3eaef9889f2e0b61484e0753200e4fa93f0986099ba4--mixxx-2.4.1-macosarm.dmg
audit for mixxx: failed
 - Upstream defined :big_sur as the minimum OS version and the cask defined :sierra
mixxx
  * Upstream defined :big_sur as the minimum OS version and the cask defined :sierra
Error: 1 problem in 1 cask detected.

@krehel
Copy link
Member Author

krehel commented May 11, 2024

Yeah, I picked the lowest macOS version for the depends_on. It's going to be angry no matter what 😅

Edit: unless you want to throw them into an on_arm / on_intel block?

@samford
Copy link
Member

samford commented May 11, 2024

Unless there's a reason not to, this is what I was using to address it locally:

  on_arm do
    depends_on macos: ">= :big_sur"
  end
  on_intel do
    depends_on macos: ">= :sierra"
  end

@krehel
Copy link
Member Author

krehel commented May 11, 2024

I'll add and push then.

Signed-off-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@BrewTestBot BrewTestBot merged commit 1afab14 into master May 11, 2024
9 checks passed
@BrewTestBot BrewTestBot deleted the bump-mixxx-2.4.1 branch May 11, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-cask-pr PR was created using `brew bump-cask-pr`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants