Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vesktop 1.5.2 (New cask) #173504

Closed
wants to merge 2 commits into from
Closed

Conversation

LTE-creator
Copy link

@LTE-creator LTE-creator commented May 11, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
    It reports that the app is not signed, weird because the dev said it was here Update apparently it is just the installer isn't.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully. (It works but i think some config files are left behind. I'll add then to zap once I figure out where they are.)

@miccal
Copy link
Member

miccal commented May 11, 2024

Thank you for your submission @LTE-creator, but we cannot accept it at this time because it does not pass our signature verification check that is a requirement for new submissions:

macOS on ARM requires software to be signed. Please contact the upstream developer to let them know they should sign and notarize their software.

Please consider hosting this in your own Tap and if the developers sign their app in the future we would then be happy to consider adding this to homebrew-cask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants