New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jslegendre-themeengine 1.0.0,118 (new cask) #171842
Conversation
Thanks for opening this, which of the following criteria does this cask meet?
|
I think it would fall under the The original repo has more stars and forks than the fork, but it has not been maintained for over 4 years. Looking into issues people tell you to navigate to the new fork. This new fork has less stars/forks but is a version of this software that is actively maintained and used by individuals. |
Let's add it with a vendor name, and we can direct people to consider that from the old cask |
I was under the assumption that discontinued casks were not allowed to exist on the repo. Did I misread the docs? |
If it's actively discontinued, yes. If it's not maintained actively... we can deprecate it. We also don't want to install a version of software people were not expecting, so we should only replace a cask source if it is abundantly clear that nobody could possibly want the original source. |
The last release was 6 years ago, and the last commit was over 4 years ago. |
And yet, it is not explicitly discontinued so deprecating as |
Sorry for the late reply! I see what you're saying, sounds good. |
I've changed the formula to include the fork author's name. Would this meet the requirements? @SMillerDev |
@SoCuul It's close, the fork author should be first in the token. |
Does this look good? |
@SMillerDev is anything else needed? |
It needs to pass CI, so there are still some adjustments needed |
Signed-off-by: Patrick Linnane <patrick@linnane.io>
@SMillerDev fixed the naming |
Thank you @SoCuul. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:- [ ] Named the cask according to the token reference.- [ ] Checked the cask was not already refused.- [ ] Checked the cask is submitted to the correct repo.- [ ]brew audit --cask --new <cask>
worked successfully.- [ ]HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.- [ ]brew uninstall --cask <cask>
worked successfully.