Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardset for the new Classic mode of Hearthstone #185

Open
lunjohnzhang opened this issue Mar 30, 2021 · 5 comments
Open

Cardset for the new Classic mode of Hearthstone #185

lunjohnzhang opened this issue Mar 30, 2021 · 5 comments

Comments

@lunjohnzhang
Copy link

Hi,

I am aware that there is a new classic mode published in the Hearthstone, which allows the players to play using the cards back in 2014. This means that CORE (basic) cards, EXPERT1 (classic), and part of HOF (Hall of Fame) will be mirrored back to their original form in 2014 within the classic mode.

I want to get the cards in their form used in the classic mode for a project. I have tried to replace the CardDefs.xml under SabberStoneCore/resources/Data/CardDefs.xml with the latest version I found in the hsdata repo. Could you please tell me:

  1. if the cards in the classic mode are included in the latest CardDefs.xml.
  2. whether there is a way in Sabberstone to get those cards.
  3. If not (to either 1 or 2), is there a way for me to effectively get those cards.

Thank you very much!

@darkfriend77
Copy link
Contributor

There is a declaration of what is included in Standard and what in Wild, you should add Classic there if it is a new playstyle.

@lunjohnzhang
Copy link
Author

To clarify, do you mean the cards of classic mode are not included in the latest CardDefs.xml?

@darkfriend77
Copy link
Contributor

They are, but they probablly arent allocated in the right mode, we would have to update it, with the latest cardDef, to obtain the correct allocations. Currently I have not enough time, but you can check a update commit to see what we normally have changed in our update process.

@rnilva
Copy link
Contributor

rnilva commented Mar 31, 2021

@lunjohnzhang After looking into few data in the latest CardDef.xml, it looks like cards with CardID = VAN_<OLD_CLASSIC_ID> are new classic cards. So

  1. Yes

You can replace the CardDef.xml first. Then a bunch of new not-implemented cards are added to class Cards. If you are not bothered, next, you should add the new classic game mode to enums. Then now you can start implementing the meaning of 'Classic Mode'. To list the tasks, the first thing to do is obviously add restrictions on cards of decks of players, and next, this would be the most annoying part, you should add conditional restrictions on card-generating tasks, to generate only allowed cards, which only has considered wild/standard modes. These generating code fragments appear in a lot of files. Finally, you should implement the effects of the new cards. As far as I know, playrequirements information is removed from CardDef.xml, so which should also be implemented. Most of the actual task implementations can be done with copy and paste though.

@lunjohnzhang
Copy link
Author

Thank you very much. I will look into it and let you know if I have more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants