Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document: Memoize entity list allocation #630

Open
XANOZOID opened this issue Jan 6, 2020 · 0 comments
Open

Document: Memoize entity list allocation #630

XANOZOID opened this issue Jan 6, 2020 · 0 comments

Comments

@XANOZOID
Copy link
Member

XANOZOID commented Jan 6, 2020

Commit in question

#574 -> Updated Scene to return empty containers

Comment

I feel like it makes sense to use some form of memoization
If we're querying the existing entity types and someone attempts to get a qualifying Entity, then cache the result as empty
much like adding an entity of that type, but with no actual allocation other than the array

Ben Morris's suggestion:

Users shouldn't be modifying these return values, that would already cause problems. We could enforce that with a read-only abstract but I don't think it's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant