Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saudi Arabia flag is wrong #23

Open
cedvdb opened this issue Apr 24, 2021 · 9 comments · May be fixed by #111
Open

Saudi Arabia flag is wrong #23

cedvdb opened this issue Apr 24, 2021 · 9 comments · May be fixed by #111

Comments

@cedvdb
Copy link

cedvdb commented Apr 24, 2021

Saudi Arabia text seems to be wrong ? That's an issue that was filed on my lib that use this. I cannot verify this claim as I don't speak arabic

@HatScripts
Copy link
Owner

Hey @cedvdb, could you please link me to the issue on your repo? So that I can get a better understanding of what the problem is. Thanks!

@waleedf112
Copy link

waleedf112 commented Apr 24, 2021

@HatScripts i filed the original issue on @cedvdb 's library.

The saudi arabian flag in the library looks like this:
Screenshot_20210424-175204__01.jpg

It supposed to look like this:
1200px-Flag_of_Saudi_Arabia.svg.png

Same thing with the iraq flag:
Screenshot_20210424-175211__01.jpg

iraq-flag.png

It way look similar to a non-arabic speaker, but they are way different

@HatScripts
Copy link
Owner

@waleedf112, I see, thank you for drawing my attention to this. I'll try to push an update as soon as possible to resolve this.

Given the nature of this flag library (flag designs being stylized/simplified such that they display better at small sizes), do you think there is room for any changes to be made to the original designs of these flags?

@waleedf112
Copy link

I understand the point of this design style, therefore, I honestly don't think you could fit it while it being readable.
it doesn't need to be THAT readable, but at least it should be in a way that it doesn't look weird because the current text is complete gibberish to Arabic readers.
you could for example make the text smaller (even if it's not readable) but it looks fine from afar.

@cedvdb
Copy link
Author

cedvdb commented Apr 25, 2021

That would result in gibberish too though and would go against the lib styling designs.

@waldyrious
Copy link
Collaborator

Would it be possible to use a symbolic Arabic letter that would represent the flag's text content without attempting to completely transcribe it? For example, the same way Wikipedia's full logo uses the word:

Wikipedia wordmark

...but the favicon uses only the W:

Wikipedia favicon

Similarly, the puzzle globe logo uses a single character to represent each language — for Arabic, it's wāw:

Could something similar be done for these flags?

@waleedf112
Copy link

Would it be possible to use a symbolic Arabic letter that would represent the flag's text content without attempting to completely transcribe it? For example, the same way Wikipedia's full logo uses the word:

Wikipedia wordmark

...but the favicon uses only the W:

Wikipedia favicon

Similarly, the puzzle globe logo uses a single character to represent each language — for Arabic, it's wāw:

Could something similar be done for these flags?

That's already the situation, the Saudi Arabian flag uses 6 letters instead of the actual 24.
The iraq flag uses 4 instead of 8.
But they are completely random, it's like instead of saying "hello there, I'm Waleed" you say "Ho Tre, m Wed"

@waldyrious
Copy link
Collaborator

So, what I'm asking is, what if, instead of them being random, we used something more symbolic? Like the first letter of the actual text, or a typically Arabic letter, something like that.

Baramiji added a commit to Baramiji/circle-flags that referenced this issue May 5, 2021
Fixing this issue:
HatScripts#23
Baramiji added a commit to Baramiji/circle-flags that referenced this issue May 5, 2021
Fixing this issue:
HatScripts#23
This was referenced May 5, 2021
@KristerL
Copy link

Hey 👋 Any updates on this? Sadly the problem still persist as the current gibberish is not good. Maybe the approach could be what was recommended before and how emoji flags have handled this? The text size is reduced, so yes it is not readable, but at least the flag is as it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@waldyrious @HatScripts @cedvdb @KristerL @waleedf112 and others