Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixed for issue #1305 #1306

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Bug fixed for issue #1305 #1306

wants to merge 6 commits into from

Conversation

Rupangkan
Copy link

Description

Fixes #1305

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@ghost
Copy link

ghost commented Mar 2, 2022 •
edited by ghost

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

HarshCasper
HarshCasper requested changes Mar 3, 2022
View reviewed changes
Copy link
Owner

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a tempCodeRunnerFile with commented out code? Also please format your code and put well-formatted comments to ensure a proper review.

@HarshCasper HarshCasper added PR:Reviewed PRs that have been reviewed. and removed PR:Ready-to-Review labels Mar 3, 2022
@Rupangkan
Copy link
Author

@HarshCasper will get into it.

@Rupangkan
Copy link
Author

@HarshCasper can you look into this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

@iamakkkhil iamakkkhil Awaiting requested review from iamakkkhil

Assignees
No one assigned
Labels
PR:Ready-to-Review PR:Reviewed PRs that have been reviewed.
Projects
None yet
Milestone
No milestone
2 participants
@Rupangkan @HarshCasper