Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SRT_REJ_BADSECRET vs. listen_callback reason #2925

Open
jeandube opened this issue Apr 11, 2024 · 0 comments
Open

[BUG] SRT_REJ_BADSECRET vs. listen_callback reason #2925

jeandube opened this issue Apr 11, 2024 · 0 comments
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@jeandube
Copy link
Collaborator

The reject reason returned by the listen_callback function of a listener is ignored if a encryption is involved.
A listener filtering incoming call based on streamID may reject without setting a configured passphrase.
A listener accepting multiple connections for different StreamID may set a different passphrase for each to-be accepted socket.
If the listener socket itself has a random passphrase the peer will receive SRT_REJ_BADSECRET instead of SRT_REJX_UNACCEPTABLE returned by the listen_callback function, which is misleading to diagnose the connection problem on the peer side.

@jeandube jeandube added the Type: Bug Indicates an unexpected problem or unintended behavior label Apr 11, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Apr 11, 2024
@maxsharabayko maxsharabayko added the [core] Area: Changes in SRT library core label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants