New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the TSBPD mode negotiation #2878

Open

maxsharabayko opened this issue Feb 15, 2024 · 0 comments

Labels

[core] Type: Enhancement

Milestone

Collaborator

maxsharabayko commented Feb 15, 2024

As of SRT v1.5.3 if one side of a connection disables TSBPD, the RCV buffering latency will not be applied.

The negotiation rule should be revised.

To Reproduce

(receiver, default latency)
./srt-xtransmit receive "srt://:4200" --enable-metrics
(sender, TSBPD disabled)
./srt-xtransmit generate "srt://127.0.0.1:4200?tsbpdmode=off" --sendrate 1Mbps -v --duration 5s --enable-metrics

(receiver, default latency)
./srt-xtransmit receive "srt://:4200?tsbpdmode=off" --enable-metrics
(sender, TSBPD disabled)
./srt-xtransmit generate "srt://127.0.0.1:4200" --sendrate 1Mbps -v --duration 5s --enable-metrics

See also #2460, #2581.

maxsharabayko added Type: Enhancement [core] labels

maxsharabayko added this to the Major milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment