Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] Check properly set epoll flags on the listener and accepted socket upon connection #1667

Open
ethouris opened this issue Nov 20, 2020 · 0 comments · May be fixed by #2732
Open

[MAINT] Check properly set epoll flags on the listener and accepted socket upon connection #1667

ethouris opened this issue Nov 20, 2020 · 0 comments · May be fixed by #2732
Assignees
@ethouris
Labels
[apps] Area: Test applications related improvements [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Milestone
Major

Comments

@ethouris
Copy link
Collaborator

Weirdly, the listener socket gets SRT_EPOLL_OUT set when a new connection reports in.

This is weird, as the listener should be only set SRT_EPOLL_IN in that case and never use SRT_EPOLL_OUT.

Might be the intention was to set SRT_EPOLL_OUT on the accepted socket, and this is likely also set in some different place. It should be verified that:

  • The listener socket gets only IN when a new socket is scheduled for acceptance
  • The accepted socket should be automatically write-ready (only buffer full event should clear this readiness).
@ethouris ethouris self-assigned this Nov 20, 2020
@ethouris ethouris added [apps] Area: Test applications related improvements [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Nov 20, 2020
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Jan 29, 2021
@maxsharabayko maxsharabayko mentioned this issue Mar 17, 2021
Closed
@maxsharabayko maxsharabayko modified the milestones: v1.4.3, v1.4.4 Mar 17, 2021
@maxsharabayko maxsharabayko linked a pull request Mar 17, 2021 that will close this issue
[core][apps] Fixed wrong +W epoll for listener socket in the test apps #1831
Closed
@maxsharabayko maxsharabayko modified the milestones: v1.4.4, v1.5.0 Aug 9, 2021
@ethouris ethouris removed a link to a pull request May 9, 2023
[core][apps] Fixed wrong +W epoll for listener socket in the test apps #1831
Closed
@ethouris ethouris linked a pull request May 9, 2023 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethouris ethouris

Labels
[apps] Area: Test applications related improvements [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
Major
Development

Successfully merging a pull request may close this issue.

[BUG] Removed setting +W for a listener socket after accept ready ethouris/srt
2 participants
@ethouris @maxsharabayko