Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precise comparison -1 by SRT_ERROR/SRT_INVALID_SOCK #2505

Open
marakew opened this issue Oct 29, 2022 · 1 comment · May be fixed by #2595
Open

precise comparison -1 by SRT_ERROR/SRT_INVALID_SOCK #2505

marakew opened this issue Oct 29, 2022 · 1 comment · May be fixed by #2595
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request [tests] Area: Unit tests Type: Maintenance Work required to maintain or clean up the code
Milestone
v1.5.4

Comments

@marakew
Copy link

marakew commented Oct 29, 2022 •
edited

there are many implicite comparisons srt error code/srt socket in folders srt/test/*
can you fix it ?
@marakew marakew added the Type: Bug Indicates an unexpected problem or unintended behavior label Oct 29, 2022
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [tests] Area: Unit tests and removed Type: Bug Indicates an unexpected problem or unintended behavior labels Nov 1, 2022
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 1, 2022
@maxsharabayko
Copy link
Collaborator

In case there would be someone willing to help with this, here is the Contribution Guide.

@maxsharabayko maxsharabayko added the help wanted Indicates that a maintainer wants help on an issue or pull request label Nov 24, 2022
@ethouris ethouris linked a pull request Dec 23, 2022 that will close this issue
Open
1 task
@maxsharabayko maxsharabayko modified the milestones: v1.5.2, v1.6.0 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request [tests] Area: Unit tests Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging a pull request may close this issue.

[BUG] Fixed the use of the right error constant ethouris/srt
2 participants
@marakew @maxsharabayko