Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Unitful in the support of PhysicalConstants #53

Open
neil-glikin opened this issue Apr 6, 2022 · 2 comments
Open

Use Unitful in the support of PhysicalConstants #53

neil-glikin opened this issue Apr 6, 2022 · 2 comments
Assignees
Labels
needs-brainstorm Further information is requested

Comments

@neil-glikin
Copy link
Collaborator

neil-glikin commented Apr 6, 2022

In the move to split-species, I removed the PhysicalConstant nature of constants which are properties of a species (eg ion mass, level energies, etc), since I was having trouble getting PhysicalConstants to work in this context (#8). We could fix this by changing the struct so that it works in this context; is it worth it? In general, I don't really see value the PhysicalConstant struct adds if it doesn't do things like understand SI prefixes or multiply two constants give give a new one with new units, but even if it could, would this be very useful?

The main problem I want to point out is that the usage of it is currently inconsistent due to the above-mentioned issue #8 (used for constants like alpha and hbar, but now not for things like the mass of Ca40).

@neil-glikin
Copy link
Collaborator Author

An alternative option: https://painterqubits.github.io/Unitful.jl/stable/

@marwahaha
Copy link
Member

I think it's a nice idea to switch to Unitful. Do you think we should do it now, or wait?

@marwahaha marwahaha added needs-brainstorm Further information is requested before-1.0 labels Apr 26, 2022
@marwahaha marwahaha self-assigned this Apr 28, 2022
@marwahaha marwahaha changed the title How do we want to use PhysicalConstants? How do we want to use PhysicalConstants (switch to unitful) Apr 28, 2022
@marwahaha marwahaha mentioned this issue May 17, 2022
@marwahaha marwahaha changed the title How do we want to use PhysicalConstants (switch to unitful) Use Unitful in the support of PhysicalConstants Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-brainstorm Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants