Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IonSim should give better error messages when vibrational modes are given in a different order #21

Open
kdbarajas opened this issue Dec 14, 2021 · 1 comment
Labels
needs-brainstorm Further information is requested

Comments

@kdbarajas
Copy link
Collaborator

Example:
# Define the initial density matrix
ρ_axial = thermalstate(axial_mode,6)
ρ_radial = thermalstate(radial_mode,6)
ρ_ions = dm(Ca["D-1/2"] ⊗ Ca["S-1/2"])
ρ_initial = ρ_ions ⊗ ρ_axial ⊗ ρ_radial
returns IonSim: Incompatible basis without further information

Temporary solution is to reorder the vibrational modes density matrix:
ρ_initial = ρ_ions ⊗ ρ_radial ⊗ ρ_axial # Corrects Incompatible basis

IonSim should be able to check for this issue and properly correct for it if the ordering doesn't matter

@kdbarajas kdbarajas added this to To do in getting to 1.0 via automation Dec 16, 2021
@marwahaha
Copy link
Member

I disagree that IonSim should automatically correct for this. We could improve the error message, like Incompatible basis. Make sure the format is (ion, radial, axial).

@marwahaha marwahaha changed the title ordering of vibrational modes in product state matters IonSim should give better error messages when vibrational modes are given in a different order Sep 23, 2022
@marwahaha marwahaha added needs-brainstorm Further information is requested and removed enhancement labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-brainstorm Further information is requested
Projects
No open projects
Development

No branches or pull requests

2 participants