Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Configuration Schema for Ion Species #108

Open
psktam opened this issue Mar 5, 2023 · 1 comment · May be fixed by #109
Open

Define Configuration Schema for Ion Species #108

psktam opened this issue Mar 5, 2023 · 1 comment · May be fixed by #109

Comments

@psktam
Copy link
Collaborator

psktam commented Mar 5, 2023

Currently, ion species are configured directly as Julia code in the src/species/<xxx>.jl files. Prefer encoding the configurations separately as read-only (ie: non-executable) files in their own dedicated location in the repository.

Suggest re-implementing these configurations in a config-only format. YAML is highly attractive as it's a relatively flexible format and is also easy to use, and there seems to be a Julia package available to parse YAML files: https://juliapackages.com/p/yaml

@psktam psktam linked a pull request Mar 18, 2023 that will close this issue
@psktam
Copy link
Collaborator Author

psktam commented Mar 18, 2023

Discussions had while developing for this issue led to additional work being done to remove IonInstance and the species-specific constructors in order to get rid of the constructor boilerplate and to clean up the class structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant