Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimburse.py Calculating Incorrect Distance #129

Open
Kironb opened this issue Sep 13, 2020 · 1 comment
Open

Reimburse.py Calculating Incorrect Distance #129

Kironb opened this issue Sep 13, 2020 · 1 comment
Assignees
Labels

Comments

@Kironb
Copy link
Collaborator

Kironb commented Sep 13, 2020

This may have to do with some google maps API changes but reimburse.py is now returning 0 for a couple of formatted addresses I tested. For example, some addresses in Pennsylvania such as "Swissvale, PA, USA" and "Pittsburgh, PA, USA" gave me 0 as a distance so subsequently returned 0 for a reimbursement amount.

I have temporarily adjusted a test to use Ohio instead which seems to be working but we should look into this.

@anthonysiu2000
Copy link
Collaborator

For the given locations Swissvale, PA, USA and Pittsburgh, PA, USA, the returned reimbursement value is no longer 0, at least according to test_reimburse.py. This applies to for all transportation methods. It seems like Google fixed it on their end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants