Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard refresh animation #513

Closed
wants to merge 2 commits into from

Conversation

leesunny790
Copy link
Contributor

@leesunny790 leesunny790 commented Nov 12, 2023

@leahlud
Copy link
Contributor

leahlud commented Nov 12, 2023

Nice!! It's so cool to see a refresh animation in the app :D

A few notes:
-the RecyclerRefreshLayout needs to be constrained to the bottom of the leaderboard title since right now it's on top of it (maybe wrap in a constraint layout? or is there a better solution)
-can we use a custom animation with this framework? (i.e. like the custom ferris wheel animation Design made last year)

@leahlud leahlud linked an issue Nov 12, 2023 that may be closed by this pull request
@leahlud
Copy link
Contributor

leahlud commented Nov 13, 2023

also, your gradle files besides should not be included in the PR besides build.gradle. You might need to make a new pull request to fix this though

@leahlud leahlud deleted the sunny/leaderboard-refresh-animation branch November 19, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

look into and add refresh animations
2 participants