Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded type assertions #79

Open
Timothy-Gonzalez opened this issue Oct 11, 2023 · 0 comments
Open

Remove unneeded type assertions #79

Timothy-Gonzalez opened this issue Oct 11, 2023 · 0 comments
Assignees

Comments

@Timothy-Gonzalez
Copy link
Member

Timothy-Gonzalez commented Oct 11, 2023

Code like:

const requestBody: SubscribeRequest = request.body as SubscribeRequest;
const emailAddress: string | undefined = requestBody.emailAddress;
const isStaff: boolean = hasStaffPerms(payload);

can be simplified to:

const requestBody = request.body as SubscribeRequest;
const emailAddress = requestBody.emailAddress;
const isStaff = hasStaffPerms(payload);

This makes TypeScript needlessly verbose and ruins the point of typescript in the first place - safety without the pain of it.

Most modern editors will show the inferred types if you hover over the variable or they can be explicitly shown if you want.

This is another issue that will conflict with anything, but this code is ugly and makes typescript more painful then it needs to be.

We can probably use something like no-unnecessary-type-assertion to fix this going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant