Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q.PAT_X_ASSUM returns bad errors #1230

Open
mn200 opened this issue May 1, 2024 · 0 comments
Open

Q.PAT_X_ASSUM returns bad errors #1230

mn200 opened this issue May 1, 2024 · 0 comments

Comments

@mn200
Copy link
Member

mn200 commented May 1, 2024

Q.PAT_X_ASSUM (aka qpat_x_assum) returns bad error messages because its implementation can't distinguish between an expected failure (the pattern not matching an unrelated assumption) and an unexpected failure (the continuation failing). Sometimes this is inevitable because there may be multiple parses for the pattern, but if there's only one, the error could be better. (Incidentally, the behaviour probably shouldn't be to try to find the first assumption that both matches the pattern and has the continuation succeed.)

Prompted by some discussion on Discord .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant