Fix #3026: resources 目录应该跟随游戏目录 #3027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3gf8jv4dv
approved these changes
May 16, 2024
There was a problem hiding this comment.
I can confirm it works. For all Releases versions and most Historical version instances, starting the game after switching the Working Directory to Isolated will play the sound normally.
Some historical versions have no sound no matter which working directory is switched, I believe this is beyond the scope of this PR.
zkitefly
reviewed
May 16, 2024
Comment on lines
+500
to
+505
| * | ||
| * @param version version installed as modpack | ||
| * @param <M> manifest type of ModpackConfiguration | ||
| * @param <M> manifest type of ModpackConfiguration | ||
| * @return modpack configuration object, or null if this version is not a modpack. | ||
| * @throws VersionNotFoundException if version does not exist. | ||
| * @throws IOException if an i/o error occurs. | ||
| * @throws IOException if an i/o error occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3026