Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复自动安装在 1.20.4 的严重问题 #3023

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

修复自动安装在 1.20.4 的严重问题 #3023

wants to merge 7 commits into from

Conversation

burningtnt
Copy link
Member

@burningtnt burningtnt commented May 3, 2024 •
edited

Close #2975 Close #3021

@burningtnt burningtnt marked this pull request as ready for review May 5, 2024 02:50
@burningtnt
Copy link
Member Author

做的差不多了，需要社区帮助测试

@burningtnt burningtnt marked this pull request as draft May 10, 2024 01:00
@burningtnt
Copy link
Member Author

burningtnt commented May 10, 2024 •
edited

Forge 做了更改，需要处理兼容性，将更改代码逻辑

@burningtnt burningtnt marked this pull request as ready for review May 10, 2024 05:22
3gf8jv4dv
3gf8jv4dv approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using a build based on burningtnt@560a9e9.

When Forge 49.0.49 and 49.0.50 are installed respectively and tested with OptiFine HD_U_I8_pre4, both can run normally. When building using the main branch (without this PR), the former cannot start the game, while the latter works fine.

In other launcher-installed instances, the Modloaders / OptiFine interface will prompt as expected: * Installed by external process, which cannot be configured. I tested Forge and Fabric installed by PCL2 and both prompted as expected.

@burningtnt
Copy link
Member Author

Good. Thanks for your detailed testing.

@burningtnt
Copy link
Member Author

By the way, may you try installing forge + optifine with the main branch, and launch the game with this PR. I've made some codes to automatically fix the optifine installed by legacy version.

@3gf8jv4dv
Copy link
Contributor

By the way, may you try installing forge + optifine with the main branch, and launch the game with this PR. I've made some codes to automatically fix the optifine installed by legacy version.

If I understand correctly: I tried installing Forge 49.0.31/49.0.49 and OptiFine HD_U_I8_pre4 on a build from the main branch, then closed and opened this PR build to launch the game directly.

But the game did not launch successfully. I checked the library file and found that the mods.toml in the OptiFine related files was not deleted. Removed and reinstalled OptiFine in the Modloaders / OptiFine interface using a PR build and the game ran as expected.

@zkitefly
Copy link
Member

By the way, may you try installing forge + optifine with the main branch, and launch the game with this PR. I've made some codes to automatically fix the optifine installed by legacy version.

If I understand correctly: I tried installing Forge 49.0.31/49.0.49 and OptiFine HD_U_I8_pre4 on a build from the main branch, then closed and opened this PR build to launch the game directly.

But the game did not launch successfully. I checked the library file and found that the mods.toml in the OptiFine related files was not deleted. Removed and reinstalled OptiFine in the Modloaders / OptiFine interface using a PR build and the game ran as expected.

可能是因为删除 mods.toml 是在安装 optifine 的时候

@burningtnt
Copy link
Member Author

burningtnt commented May 11, 2024 •
edited

可能是因为删除 mods.toml 是在安装 optifine 的时候

I've made some changes to check OptiFine while checking whether the game is conplete. Maybe there's a bug here.

@burningtnt
Copy link
Member Author

Has been fixed yesterday but I forgot to send a messsage. There should NOT be any bugs. (?)

@3gf8jv4dv
Copy link
Contributor

Has been fixed yesterday but I forgot to send a messsage. There should NOT be any bugs. (?)

I saw the commit you pushed earlier, but I was dealing with other things at the time. I will test it later.

@3gf8jv4dv
Copy link
Contributor

3gf8jv4dv commented May 16, 2024 •
edited

Tested using release-3.5.8 (release) and a build based on burningtnt@200cc50.

Builds based on this PR now correctly fix OptiFine library files under Forge & OptiFine instances for 1.20.4 installed through a launcher that does not contain this PR.

3gf8jv4dv
3gf8jv4dv approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it seems there is no problem.

@burningtnt burningtnt changed the title 修复自动安装在新版本各大组件的 Breaking Change 下会各种爆炸的问题 修复自动安装在 1.20.4 会有严重问题 May 17, 2024
@burningtnt burningtnt changed the title 修复自动安装在 1.20.4 会有严重问题 修复自动安装在 1.20.4 的严重问题 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkitefly zkitefly zkitefly approved these changes

@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@burningtnt @3gf8jv4dv @zkitefly