Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Setup i18n with next-intl #1657

Closed
rylew1 opened this issue Apr 9, 2024 · 5 comments · Fixed by #1851
Closed

[Task]: Setup i18n with next-intl #1657

rylew1 opened this issue Apr 9, 2024 · 5 comments · Fixed by #1851
Assignees
@acouch
Labels
project: grants.gov Grants.gov Modernization tickets
Milestone
Search UI - Enhan...

Comments

@rylew1
Copy link
Collaborator

rylew1 commented Apr 9, 2024

Summary

setup i18n with next-intl

Acceptance criteria

Internationalization works on app router pages
@rylew1 rylew1 added the project: grants.gov Grants.gov Modernization tickets label Apr 9, 2024
@margaretspring margaretspring mentioned this issue Apr 1, 2024
Closed
1 task
@acouch
Copy link
Collaborator

acouch commented Apr 10, 2024

@rylew1 is the approach to have two sets of i18n folders until #1361 is done?

@acouch
Copy link
Collaborator

acouch commented Apr 11, 2024 •
edited

@rylew1 this approach could be a quick fix initially 7d41ab7#diff-0df8a6933bb9d8397e13f2e5f8799e5603a12d421c0a672ea2803e133622a4e6L28

This approach was taken care of in #1760

This was referenced Apr 16, 2024
Closed
Merged
@acouch
Copy link
Collaborator

acouch commented Apr 18, 2024

Noting from @rylew1 comment on #1760 (comment) that we could add the metadata to the layout once we are using the page strings.

@acouch acouch assigned acouch and unassigned rylew1 Apr 23, 2024
@acouch
Copy link
Collaborator

acouch commented Apr 24, 2024

I started this locally, will try and push a branch before cob.

@acouch
Copy link
Collaborator

acouch commented Apr 25, 2024

I have this working, needs a lot of clean up https://github.com/HHS/simpler-grants-gov/tree/acouch/issue-acouch-i18n/frontend

This was referenced Apr 26, 2024
Closed
Merged
@acouch acouch mentioned this issue May 6, 2024
Merged
acouch added a commit that referenced this issue May 7, 2024
@acouch
[Issue #1657] Setup Next-Intl for App Pages (#1851)
35d6fe5 
## Summary
Fixes #1657 

### Time to review: __30 mins__

## Changes proposed
Enables next-intl to enable translation for app pages. This sets up
next-intl and enables it for the search page and app not found page.
This adds one other app component. There are three which will be removed
for #1361 .

## Context for reviewers
The strings being declared and injected is still ugly and not addressed
with this, but will be fixed with #1361 .

The `[locale]` folder has not been setup yet b/c it took over the full
routing for the site. That folder will be setup in #1361 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acouch acouch

Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler Grants Sprint Planning
Status: Done
Milestone
Search UI - Enhancements and fast follow
3 participants
@acouch @rylew1 @sumiat