Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Frontend tests for server components (search page, page not found) #1393

Open
rylew1 opened this issue Mar 4, 2024 · 2 comments
Open

[Task]: Frontend tests for server components (search page, page not found) #1393

rylew1 opened this issue Mar 4, 2024 · 2 comments
Assignees
@rylew1
Labels
project: grants.gov Grants.gov Modernization tickets
Milestone
Search UI - Enhan...

Comments

@rylew1
Copy link
Collaborator

rylew1 commented Mar 4, 2024 •
edited by sumiat

Summary

  • Create new pattern for server component page tests
  • Fix existing tests that are failing/commented out - IE: search.test.tsx

Acceptance criteria

  • search.test.tsx successfully tests against a server component
  • not-found.test.tsx tests against server component

Notes

  • Testing: server component search page gets initial results and passes to client component
  • For the not found page: checking strings
@rylew1 rylew1 added the project: grants.gov Grants.gov Modernization tickets label Mar 4, 2024
@rylew1 rylew1 changed the title [Task]: Create server component tests [Task]: Create server component test for search page Mar 5, 2024
@rylew1 rylew1 changed the title [Task]: Create server component test for search page [Task]: Create server component test for search page, page not found Mar 7, 2024
@sumiat sumiat removed the refinement label Mar 19, 2024
@rylew1 rylew1 self-assigned this Apr 1, 2024
@rylew1 rylew1 changed the title [Task]: Create server component test for search page, page not found [Task]: Frontend tests for server components (search page, page not found) Apr 1, 2024
@rylew1 rylew1 mentioned this issue Apr 2, 2024
Closed
@acouch
Copy link
Collaborator

acouch commented Apr 15, 2024

@rylew1 can we move this to: https://github.com/HHS/simpler-grants-gov/milestone/155 since it is something we want to do before closing this line of work but is not blocking users from testing the search page?

@rylew1 rylew1 mentioned this issue Apr 16, 2024
Closed
@rylew1
Copy link
Collaborator Author

rylew1 commented Apr 26, 2024

@sumiat I think we should put this one on hold in favor of working on the e2e ticket #1757 - the e2e tests will basically cover the server components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylew1 rylew1

Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler Grants Sprint Planning
Status: Sprint Ready
Milestone
Search UI - Enhancements and fast follow
Development

Successfully merging a pull request may close this issue.

[Issue #1393]: Server component test HHS/simpler-grants-gov
3 participants
@acouch @rylew1 @sumiat