Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor GET Agreement response schema #2239

Open
4 tasks
jonnalley opened this issue Apr 24, 2024 · 0 comments · May be fixed by #2330
Open
4 tasks

refactor GET Agreement response schema #2239

jonnalley opened this issue Apr 24, 2024 · 0 comments · May be fixed by #2330
Assignees
@rajohnson90
Labels
tech-debt Resolved technical debt (tooling, configuration, or workflow)

Comments

@jonnalley
Copy link
Contributor

Goals

  • Eradicate the growing mess of to_dict stuff in the backend API response schema
  • Use more marshmallow

Tasks

  • Identify the problem
  • Fix It
  • Repeat until all problems are FIXED
  • Leave the code better than you found it

Additional Context

  • Please use marshmallow.Schema and not desert or marshmallow-dataclass - plain marshmallow is more fully featured, better documented, and is more supported/mature than the others

Resources
@jonnalley jonnalley added the tech-debt Resolved technical debt (tooling, configuration, or workflow) label Apr 24, 2024
@rajohnson90 rajohnson90 self-assigned this May 10, 2024
@rajohnson90 rajohnson90 linked a pull request May 20, 2024 that will close this issue
Draft
10 tasks
@rajohnson90 rajohnson90 linked a pull request May 20, 2024 that will close this issue
DRAFT Ops 2239/refactor get response schema #2330
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajohnson90 rajohnson90

Labels
tech-debt Resolved technical debt (tooling, configuration, or workflow)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DRAFT Ops 2239/refactor get response schema HHS/OPRE-OPS
2 participants
@jonnalley @rajohnson90