Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budget Change: Edit Procurement Shop (including prompt for send to approval) #2167

Open
18 tasks
jonnalley opened this issue Apr 8, 2024 · 1 comment
Open
18 tasks
Labels
design this is a design task story A defined user story adhering to expected norms including a narrative

Comments

@jonnalley
Copy link
Contributor

jonnalley commented Apr 8, 2024

User Story

As a COR, I need to edit the procurement shop on an agreement with with no BLs in a status higher than Planned, and know that it requires an approval, so that I understand how my edit will impact the overall budget

Preconditions

  • A contract exists with at least one budget line in Planned status but no budget lines in any status higher than that.

Acceptance Criteria

  • On a given existing contract, authorized users are able to select a different procurement shop from the one currently selected and the changes are successfully persisted without altering the status of Planned budget lines. Authorized users would be limited to Project officer, named team members, Division Director linked to associated CANs, and System Admin(s).
  • Changing the procurement shop should not be allowed if the contract has any BLs in Executing or higher status unless the user is a System Admin (are we able to qualify based on user/group role at this time?)
  • The user should be aware that making the procurement shop change will require re-approval
  • Validation rules would still need to be enforced on contract metadata such that required attributes based on the associated BL status can't be emptied out or otherwise made invalid
  • Upon successful committal of the pending procurement shop change, if a given contract has one or more BLs in Planned status such that changing the Procurement shop requires approval, the stored fee amount should not change at this time
    • A contract with only draft BLs should have all the fees updated based on the procurement shop change.
  • Upon successful committal of the pending procurement shop change, relevant entries should be recorded in the event/history table(s) of who made what changes when and this event should be properly rendered in the history of changes to the agreement.

Test

  • Upon submitting the new procurement shop for approval, the agreement should still have the original procurement shop in place/rendered until it's approved.
  • If all BLs are in draft state, no approval would be required anyway.
  • If at least one BL is in planned state, approval for the proc shop change would be required.
  • Even if approval is required, original fees shown pre-change would still persist until approved.

Tasks

UX

Dev

Definition of Done Checklist

  • UI works as designed (UX team)
  • PR(s) have been merged to main
  • Design/tech debt eliminated
  • New design/tech debt documented (if applicable)
  • Build process updated
  • Documentation updated or added
  • Feature flags/toggles created

Additional Context & Resources

@jonnalley jonnalley added draft draft only, not ready for prime time. still being authored or needs refinement story A defined user story adhering to expected norms including a narrative labels Apr 8, 2024
@jonnalley jonnalley added design this is a design task and removed draft draft only, not ready for prime time. still being authored or needs refinement labels Apr 15, 2024
@kimschulke kimschulke changed the title Change procurement shop (approval) Budget Change: Procurement Shop (including prompt for send to approval) Apr 19, 2024
@kimschulke kimschulke changed the title Budget Change: Procurement Shop (including prompt for send to approval) Budget Change: Edit Procurement Shop (including prompt for send to approval) Apr 19, 2024
@fpigeonjr
Copy link
Contributor

🤔wonder if this bug #2079 will be resolved with this user-story?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design this is a design task story A defined user story adhering to expected norms including a narrative
Projects
None yet
Development

No branches or pull requests

2 participants