Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fees on BLIs should not be snapshotted for non-obligated status #2139

Open
11 tasks
jonnalley opened this issue Mar 29, 2024 · 1 comment
Open
11 tasks

Fees on BLIs should not be snapshotted for non-obligated status #2139

jonnalley opened this issue Mar 29, 2024 · 1 comment
Labels
Improvement story A defined user story adhering to expected norms including a narrative

Comments

@jonnalley
Copy link
Contributor

jonnalley commented Mar 29, 2024 •
edited

User Story

  • As an OPS user, I want procurement shop fees to be always dynamically calculated and not snapshotted/stored when a given budget line is in Draft, Planned, or Executing status so that the most-correct and up-to-date fee can always be represented and shown.

Acceptance Criteria

  • A budget line in draft, planned, or Executing status does not have a persistently stored fee associated
  • When budget lines are returned to the user, the fee calculation should always be dynamic and calculated ad-hoc when the BL is in draft, planned, or Executing status
  • BL totals and any agreement totals should use the ad-hoc/dynamic calculation of the fee.

Tasks

  • Decide how this will impact CAN balances and their calculation?

UX

  • shouldn't be any UX changes here ?

Dev

Definition of Done Checklist

  • UI works as designed (UX team)
  • PR(s) have been merged to main
  • Design/tech debt eliminated
  • New design/tech debt documented (if applicable)
  • Build process updated
  • Documentation updated or added
  • Feature flags/toggles created

Additional Context & Resources
@jonnalley jonnalley added draft draft only, not ready for prime time. still being authored or needs refinement story A defined user story adhering to expected norms including a narrative labels Mar 29, 2024
@jonnalley jonnalley changed the title Fees on BLIs should not be snapshotted for draft and Planned status Fees on BLIs should not be snapshotted for non-obligated status Apr 8, 2024
@jonnalley
Copy link
Contributor Author

This seems to be in opposition to and an opposing need from #1473, FWIW

@jonnalley jonnalley mentioned this issue May 7, 2024
Open
@jonnalley jonnalley added Improvement and removed draft draft only, not ready for prime time. still being authored or needs refinement labels May 7, 2024
@jonnalley jonnalley mentioned this issue May 7, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement story A defined user story adhering to expected norms including a narrative
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonnalley