Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hard coded division directors and incorrect approvers in workflows #2134

Open
stevtek opened this issue Mar 26, 2024 · 0 comments
Open

hard coded division directors and incorrect approvers in workflows #2134

stevtek opened this issue Mar 26, 2024 · 0 comments
Labels
bug Something isn't working tech-debt Resolved technical debt (tooling, configuration, or workflow)

Comments

@stevtek
Copy link
Contributor

stevtek commented Mar 26, 2024

The IDs of the division directors are hard coded in create_notification_for_division_directors
Also, the approvers are set in the template, so they can't be set to the correct approvers for a given BLI. The template effectively hards codes them for all instances.
@stevtek stevtek added bug Something isn't working tech-debt Resolved technical debt (tooling, configuration, or workflow) labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tech-debt Resolved technical debt (tooling, configuration, or workflow)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevtek