Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable limit for Volume filters #226

Open
HEnquist opened this issue Aug 21, 2022 · 4 comments
Open

Configurable limit for Volume filters #226

HEnquist opened this issue Aug 21, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@HEnquist
Copy link
Owner

Volume filters should have min and max parameters. If the volume is set to a value outside the allowed range, the actual applied value should be clamped at the nearest limit.

@HEnquist HEnquist added the enhancement New feature or request label Aug 21, 2022
@HEnquist HEnquist added this to the 1.1 milestone Aug 21, 2022
@timsurber
Copy link

@HEnquist This is set as completed, but where can I set the clamp limit?

@HEnquist
Copy link
Owner Author

HEnquist commented Apr 1, 2024

This was not implemented as described here. Instead I added a limiter filter. It's a different but not equivalent solution to the problem of limiting the max volume going out. I should have added a comment about that when I closed this issue. And I probably should not have closed it. I'll reopen and implement this for 3.0.

@timsurber
Copy link

@HEnquist Would you consider adding a lower limit as well?
When controlling it with an remote it can happen that you press the volume down button too long accidently, and then it can take quite a while to get up again.

@HEnquist
Copy link
Owner Author

HEnquist commented Apr 3, 2024

Adding a lower limit won't help with that. The limit does not limit what values the websocket interface accepts, it only clamps what the volume control actually applies.

@HEnquist HEnquist modified the milestones: 2.0, 3.0 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants