Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converter: run conversion asynchronously via Celery if offline=True #563

Open
GraemeWatt opened this issue Nov 15, 2022 · 0 comments
Open
Labels
complexity: high priority: medium type: bug Indicates an unexpected problem or unintended behaviour

Comments

@GraemeWatt
Copy link
Member

The convert_and_store function calls download_submission with an argument offline=True, in turn calling convert_zip_archive which performs the conversion using hepdata-converter-ws-client, hepdata-converter-ws and hepdata-converter. However, the conversion is performed synchronously and large submissions can encounter a 5-minute server timeout. It would be better if the offline=True option was propagated to hepdata-converter-ws which would then run hepdata_converter.convert asynchronously as a Celery task, writing the output directly to the converted folder of the data directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: high priority: medium type: bug Indicates an unexpected problem or unintended behaviour
Projects
Status: To do
Development

No branches or pull requests

1 participant