Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse score for GWT-Material apps decreased due to unload listener in older embedded JQuery #1043

Open
garthhenning opened this issue Feb 21, 2024 · 1 comment

Comments

@garthhenning
Copy link

Google Lighthouse now scores use of an unload listener poorly for their "Best Practices" score.

   https://web.dev/articles/bfcache?utm_source=lighthouse&utm_medium=devtools#never_use_the_unload_event

GWT-Material v2.8.3 has an embedded dependency on JQuery v3.5.1. JQuery v3.5.1 attaches unload listeners. JQuery corrected this in v3.7.1.

   https://github.com/jquery/jquery/issues/5323

Updating the embedded JQuery would mean web sites using GWT-Material no longer get their scores decremented.

@kevzlou7979
Copy link
Contributor

kevzlou7979 commented Feb 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants