Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

[Ticker] key for mapped components should be more unique, rather than just indices #105

Open
AdityaVandan opened this issue Oct 26, 2021 · 1 comment
Open

[Ticker] key for mapped components should be more unique, rather than just indices #105

AdityaVandan opened this issue Oct 26, 2021 · 1 comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right

Comments

@AdityaVandan
Copy link
Contributor

https://github.com/Groww/ui-toolkit/blame/ea3d4afb496ee7ea0199827ff40621a85125dbfc/src/components/atoms/Ticker/Ticker.tsx#L34

line 34 and 49
@AdityaVandan AdityaVandan added help wanted Extra attention is needed invalid This doesn't seem right labels Oct 26, 2021
@vaibhav111tandon
Copy link

Hey, Can I try this out? Though it seems that unique keys(apart from indices) will further break the component due to rendering, i.e. animation can be affected.
So either indices or something similar to that like having some fixed hash for numbers can make it stand out from indices. yet it does not give upper hand as per me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vaibhav111tandon @AdityaVandan